From: Colin Walters <walters@verbum.org>
Date: Thu, 5 May 2011 20:28:05 +0000 (-0400)
Subject: StTextureCache: plug leak in not-found icon case
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~8267
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=dcd07eb23ff763c84d898a4d9ec886001220eb49;p=gnome-shell.git

StTextureCache: plug leak in not-found icon case

Need to free the key too.

https://bugzilla.gnome.org/show_bug.cgi?id=649508
---

diff --git a/src/st/st-texture-cache.c b/src/st/st-texture-cache.c
index 182851bad..fba794aaf 100644
--- a/src/st/st-texture-cache.c
+++ b/src/st/st-texture-cache.c
@@ -1223,10 +1223,11 @@ load_gicon_with_colors (StTextureCache    *cache,
   else
     {
       /* Blah; we failed to find the icon, but we've added our texture to the outstanding
-       * requests.  In that case, just undo what create_texture_lookup_status did.
+       * requests.  In that case, just undo what create_texture_and_ensure_request() did.
        */
        g_slist_foreach (request->textures, (GFunc) g_object_unref, NULL);
        g_slist_free (request->textures);
+       g_free (request->key);
        g_free (request);
        g_hash_table_remove (cache->priv->outstanding_requests, key);
        g_object_unref (texture);